Repository navigation
Fix the declaration of license data - #1451
Merged
Merged
Conversation
Our existing declaration of `project.license.text` does not align with our intent: we are stating that "Apache-2.0" is *the full text of our license*. We mean to be stating it as an SPDX license expression. Updating to the newer license metadata format fixes this: `project.license` is published as `License-Expression`. This fix causes `setuptools` to fail, raising an error regarding the combination of `project.license` and the license classifier. (The license classifier is deprecated; `setuptools` has chosen to reject it in this circumstance.)
sirosen
requested review from
MaxTueckeGlobus,
derek-globus,
kurtmckee and
m1yag1
as code owners
November 12, 2026 02:53
This comment was marked as resolved.
This comment was marked as resolved.
derek-globus
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this issue while developing
mddj read license. When I ran it on the SDK, I got the following result:With this fix, I get the corrected:
Our existing declaration of
project.license.textdoes not align withour intent: we are stating that "Apache-2.0" is the full text of our
license. We mean to be stating it as an SPDX license expression.
Updating to the newer license metadata format fixes this:
project.licenseis published asLicense-Expression.This fix causes
setuptoolsto fail, raising an error regarding thecombination of
project.licenseand the license classifier. (The licenseclassifier is deprecated;
setuptoolshas chosen to reject it in thiscircumstance.)